Add an integration test matching our quick start #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def test_basic_usage(): | ||
| """This matches the quick start example in our documentation.""" |
There was a problem hiding this comment.
add a hyperlink here?
There was a problem hiding this comment.
No links live yet. I'll just say it's in our base README. I don't think we need to link a specific branch of the README.
| import keras_nlp | ||
|
|
||
|
|
||
| def test_basic_usage(): |
There was a problem hiding this comment.
I have a general question here - do we want to use tf.test for integration tests?
There was a problem hiding this comment.
I'm not sure if it makes much difference here, but it seems good to use it for consistency. Switched.
chenmoneygithub
approved these changes
May 9, 2022
|
|
||
|
|
||
| def test_basic_usage(): | ||
| """This matches the quick start example in our documentation.""" |
There was a problem hiding this comment.
add a hyperlink here?
|
|
||
|
|
||
| def test_basic_usage(): | ||
| """This matches the quick start example in our documentation.""" |
| import keras_nlp | ||
|
|
||
|
|
||
| def test_basic_usage(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.