Skip to content

Update BERT example's README with data downloading instructions #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2022
Merged

Update BERT example's README with data downloading instructions #169

merged 2 commits into from
May 5, 2022

Conversation

chenmoneygithub
Copy link
Contributor

  1. Add curl download instruction to BERT README.
  2. Add guidance on how to preview generated tfrecord.

@mattdangerw
Copy link
Member

Looks good to me! Discussed offline, but let's ditch the bookscorpus download link, I don't think we have a reliable mirror there. Better to link to that repository which is attempting to document the ways to create the dataset.

mattdangerw
mattdangerw approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattdangerw mattdangerw merged commit 2b2e7a8 into keras-team:master May 5, 2022
@chenmoneygithub chenmoneygithub deleted the small-fix branch May 9, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenmoneygithub @mattdangerw