Remove preprocessing layers we no longer use #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, all our causal lm models had a preprocessing layer base class that packed inputs without setting things up for the causal language model loss. With our new base classes, `CausalLMPreprocessor` and `Seq2SeqLMPreprocessor`, these are no longer used at all. These are public, but I did a search for them on GitHub and the only one I could find with any usage is `GPT2Preprocessor`. The others are complete unused, and not generally very useful. Let's remove them before anyone does depend on them so that we can keep preprocessing one-to-one paired with a task. E.g. ``` BertTextClassifier BertTextClassifierPreprocesssor ```
mattdangerw
force-pushed
the
delete-useless-layers
branch
from
d54d9bc to
4ea0ff1
Compare
mattdangerw
changed the title
divyashreepathihalli
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, all our causal lm models had a preprocessing layer base class that packed inputs without setting things up for causal language modeling. With our new base classes,
CausalLMPreprocessorandSeq2SeqLMPreprocessor, these are no longer used at all.These are public, but I did a search for them on GitHub and the only one I could find with any usage is
GPT2Preprocessor. The others are complete unused, and not generally very useful.Let's remove these before anyone does depend on them so that we can keep preprocessing one-to-one with a task. E.g. it should always look like this: