Skip to content

Fix Loose Dependency Imports #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2022
Merged

Fix Loose Dependency Imports #199

merged 2 commits into from
May 24, 2022

Conversation

abheesht17
Copy link
Collaborator

Resolves #198

mattdangerw
mattdangerw requested changes May 23, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one small comment. You could also add a note about about adding the dependency to the setup.py testing dependency list so we can still test things out.

API_DESIGN_GUIDE.md Outdated
try:
import rouge_score
except ImportError:
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in issue, we should just do rouge_score = None to avoid needing to mess with sys.modules.

@mattdangerw
Copy link
Member

lgtm!

@mattdangerw mattdangerw merged commit 1dc32d8 into keras-team:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Loose Dependency Imports
2 participants
@abheesht17 @mattdangerw