Skip to content

Fix dtype when creating a task with a task.json #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix dtype when creating a task with a task.json #2007

merged 1 commit into from
Dec 5, 2024

Conversation

mattdangerw
Copy link
Member

@mattdangerw mattdangerw commented Dec 5, 2024 •
edited
Loading

Flagged by @martin-gorner

keras_hub.models.CausalLM.from_preset("hf://google/gemma-2-instruct-9b-keras", dtype="bfloat16")

Will fail. We have an issue properly handling dtype passed to the model when restoring a task.

@github-actions github-actions bot added the Gemma Gemma model specific issues label Dec 5, 2024
@mattdangerw mattdangerw merged commit 3f80160 into keras-team:master Dec 5, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffcarp jeffcarp jeffcarp approved these changes

@divyashreepathihalli divyashreepathihalli Awaiting requested review from divyashreepathihalli

@SamanehSaadat SamanehSaadat Awaiting requested review from SamanehSaadat

Assignees
No one assigned
Labels
Gemma Gemma model specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @jeffcarp