Use Ruff for formatting #2019
Merged
Use Ruff for formatting #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamanehSaadat
approved these changes
Dec 12, 2024
CONTRIBUTING.md
Outdated
| ## Formatting Code | ||
|
|
||
| We use `flake8`, `isort` and `black` for code formatting. You can run | ||
| Keras uses [Ruff](https://docs.astral.sh/ruff/) to format the code. You can run |
There was a problem hiding this comment.
Don't we want to say KerasHub instead of Keras here?
| x: Input tensor of shape (batch_size, input_dim). | ||
| Returns: | ||
| KerasTensor: The RMS-normalized tensor of the same shape (batch_size, input_dim), |
There was a problem hiding this comment.
Did Ruff automatically removed KerasTensor from here or you removed it manually? 🤔
There was a problem hiding this comment.
I removed it manually while fixing line length issues. We can return either a kerastensor (symbolic tensor) or torch or jax or tf tensor. Better to just say tensor and shorter for line length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keras is doing it, and we should follow suit. keras-team/keras#20445
But also it's simpler and faster!