New tools for model preset admin #2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
force-pushed
the
new-checkpoint-tools
branch
2 times, most recently
from
2ace8c8 to
6641928
Compare
SamanehSaadat
approved these changes
Dec 20, 2024
tools/admin/update-all-json.py
Outdated
| if file.name == "config.json": | ||
| print(" ", "metadata.json") | ||
| saver._save_metadata(layer) | ||
| name = "metadata.json" |
There was a problem hiding this comment.
Is this branch for metadata.json or config.json? if says config.json but print and name are metadata.json 🤔
There was a problem hiding this comment.
nit: probably using these consts make the maintenance of this code easier if it's not a one-time-use code: https://github.com/keras-team/keras-hub/blob/master/keras_hub/src/utils/preset_utils.py#L48-L55
There was a problem hiding this comment.
I'll clarify in the comments, we handle the config.json and metadata.json in the same iter of this for loop, just because it's how our saving utils work (they are saved together).
There was a problem hiding this comment.
updated the file constants!
mattdangerw
force-pushed
the
new-checkpoint-tools
branch
2 times, most recently
from
4f0b7d2 to
39e5e14
Compare
A tool to update all json files for a preset (by running them through Keras' serialize and deserialize routines). A tool to update all preset version in the library to the latest version on kaggle.
mattdangerw
force-pushed
the
new-checkpoint-tools
branch
from
39e5e14 to
f5ca987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tool to update all json files for a preset (by running them through Keras' serialize and deserialize routines).
A tool to update all preset version in the library to the latest version on kaggle.