Skip to content

Vit bug #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

Vit bug #2070

merged 2 commits into from
Feb 3, 2025

Conversation

sineeli
Copy link
Collaborator

@sineeli sineeli commented Feb 3, 2025 •
edited
Loading

  • Add missing dropout arg
  • As per official implementation a dropout layer was missing in MLP, which was not existing huggingface implementation, so just added a dropout layer

@abheesht17 thanks for pointing it out.

mattdangerw
mattdangerw approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattdangerw mattdangerw merged commit 4ecbadf into keras-team:master Feb 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sineeli @mattdangerw