Skip to content

Conversation

buildwithsuhana
Copy link
Contributor

@buildwithsuhana buildwithsuhana commented Aug 27, 2025

This PR fixes the dtype error causing the failure if CLIPBackboneTest.test_backbone_basics. The test gave a value error saying:
ValueError: Incompatible type conversion requested to type int32 for `tf.Variable of type int64.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @buildwithsuhana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a ValueError related to incompatible data types (int32 vs int64) that was causing a test failure in CLIPBackboneTest.test_backbone_basics. The fix involves explicitly casting integer operands to float32 before performing division and logarithm operations within the _make_log_bucket_position function of the DeBERTaV3 model's disentangled self-attention mechanism, ensuring correct floating-point arithmetic and preventing type conversion errors.

Highlights

  • Data Type Correction: Explicitly cast abs_pos, mid, and self.max_position_embeddings - 1 to float32 before division and logarithm operations in _get_log_pos function.
  • Error Resolution: Resolves a ValueError related to incompatible int32 and int64 types during tf.Variable conversion, which was causing CLIPBackboneTest.test_backbone_basics to fail.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a dtype error in DisentangledSelfAttention by explicitly casting integer tensors to float32 before division and logarithm operations. The fix is correct and addresses the issue. I've added one suggestion to refactor the updated function slightly for improved readability and to avoid a redundant operation.

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Aug 27, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 27, 2025
@abheesht17 abheesht17 merged commit 64205cb into keras-team:master Aug 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants