Skip to content

Add a learned positional embedding layer #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2022
Merged

Add a learned positional embedding layer #47

merged 1 commit into from
Apr 4, 2022

Conversation

hertschuh
Copy link
Contributor

No description provided.

hertschuh
hertschuh commented Mar 16, 2022
View reviewed changes
chenmoneygithub
chenmoneygithub reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

mattdangerw
mattdangerw reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great!

@mattdangerw mattdangerw mentioned this pull request Mar 22, 2022
Closed
fchollet
fchollet reviewed Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

mattdangerw
mattdangerw approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few last comments.

mattdangerw
mattdangerw approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattdangerw mattdangerw merged commit 0fd7a89 into keras-team:master Apr 4, 2022
@mattdangerw mattdangerw mentioned this pull request Apr 4, 2022
Closed
adhadse pushed a commit to adhadse/keras-nlp that referenced this pull request Sep 17, 2022
@hertschuh
Add a learned positional embedding layer (keras-team#47)
76b4cd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet left review comments

@mattdangerw mattdangerw mattdangerw approved these changes

+1 more reviewer

@chenmoneygithub chenmoneygithub chenmoneygithub approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hertschuh @fchollet @mattdangerw @chenmoneygithub