-
Notifications
You must be signed in to change notification settings - Fork 301
retrained bert_tiny_uncased_en_sst2_training.ipynb #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retrained bert_tiny_uncased_en_sst2_training.ipynb #771
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I signed the form so |
Hi @chenmoneygithub I finetuned |
@susnato Thanks a lot! Looks beautiful overall! Another thing you may want to do is to use a decayed learning rate:
Please let me know how it works, thx again! |
Just a drive by comment, but we should replace, not copy, the old colab with this PR. We don't want to keep spawning versions of the colab each time we update something. |
Hi @chenmoneygithub thanks for the reply! I ran as you instructed, it gave -
Since it's working relatively worse should I stick with constant |
@susnato Hi! sorry for the late reply, I was on vacation the last week. This is a bit odd to me, in my experiments the decayed lr generally works better (but I tried it with BERT base model). If this is stable on your side, it sounds good to stay with the constant |
"nbformat_minor": 0 | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline at the end
"visibility": null, | ||
"width": "20px" | ||
} | ||
"cell_type": "code", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: delete the empty cell
6c5136d
to
1cfd306
Compare
Hi @chenmoneygithub thanks a lot for your comments! I made the changes you requested, please check them. |
@susnato Oh one more thing - could you run ./shell/format.sh in your branch? the style check is broken. |
@chenmoneygithub Done! |
03866b4
to
bceae22
Compare
Hi @chenmoneygithub the |
@susnato That one is okay, don't worry. |
What does this PR do?
As discussed in this issue, this PR updates the previous training script for finetuning BERT on SST2.
The colab link is this : https://colab.research.google.com/drive/1afTO0ahF3vZrJtkVSGXwBLV2OGeDfomL?usp=sharing
Valdiation Scores achieved :
@chenmoneygithub