-
Notifications
You must be signed in to change notification settings - Fork 301
Add Whisper Backbone #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Whisper Backbone #801
Conversation
keras_nlp/models/whisper/whisper_cached_multi_head_attention.py
Outdated
Show resolved
Hide resolved
Reverting back to the original since we can't set "trainable" for weights:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Just some small comments, but let's add tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a last round of comments I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits. But let's merge after that!
# The number of mel-frequency filters. We hardcode this to 80: | ||
# https://github.com/openai/whisper/blob/v20230124/whisper/audio.py#L101-L102. | ||
# TODO: If needed, we can make it configurable. | ||
num_mels = 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do NUM_MELS = 80
after the import block but before the class, that is approach we have used before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Excited for this.
Ta-da!
https://colab.research.google.com/drive/1BhEVK2NpOUICgi8ThLt7Qogzk3DqTJjQ?usp=sharing