Skip to content

Conversation

fchollet
Copy link
Collaborator

@fchollet fchollet commented Mar 9, 2023

No description provided.

@mattdangerw
Copy link
Member

mattdangerw commented Mar 9, 2023

We should actually just do the full list below I think! Preprocessing and trainable layers.

https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/layers/__init__.py#L15-L31

@mattdangerw mattdangerw self-requested a review March 9, 2023 22:45
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing TransformerEncoder I think!

Also worth noting these are all documented, we just currently list them in two places
https://keras.io/api/keras_nlp/modeling_layers/
https://keras.io/api/keras_nlp/preprocessing_layers/
(happy to change that, no strong feelings)

@fchollet
Copy link
Collaborator Author

fchollet commented Mar 9, 2023

Still missing TransformerEncoder I think!

That one was part of the original PR. It's already covered.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah whoops! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants