Add API exports for models documented on keras.io #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Mar 9, 2023
|
|
||
|
|
||
| @keras.utils.register_keras_serializable(package="keras_nlp") | ||
| @keras_nlp_export("keras_nlp.models.albert.AlbertBackbone") |
There was a problem hiding this comment.
You should use the public path (as documented on keras.io, e.g. https://keras.io/api/keras_nlp/models/albert/albert_backbone/#albertbackbone-class). Here it is "keras_nlp.models.AlbertBackbone". Same for the other symbols!
There was a problem hiding this comment.
sure ! will make the change
fchollet
approved these changes
Mar 9, 2023
|
|
||
|
|
||
| @keras.utils.register_keras_serializable(package="keras_nlp") | ||
| @keras_nlp_export("keras_nlp.models.Task") |
There was a problem hiding this comment.
I think it's fine to export this one, though it's not in the init file. As a general rule to apply the next time: please only include symbols that are currently in the init file, e.g. models/__init__.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #812