Skip to content

Call super.config() in BartBackbone's get_config() #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

Call super.config() in BartBackbone's get_config() #818

merged 3 commits into from
Mar 10, 2023

Conversation

kanpuriyanawab
Copy link
Collaborator

Closes #813

mattdangerw
mattdangerw requested changes Mar 9, 2023
View reviewed changes
mattdangerw
mattdangerw approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment, then let's merge

@mattdangerw
Copy link
Member

LGTM!

@mattdangerw mattdangerw merged commit 56cf284 into keras-team:master Mar 10, 2023
@kanpuriyanawab kanpuriyanawab deleted the bart-config branch March 10, 2023 17:56
@kanpuriyanawab kanpuriyanawab restored the bart-config branch March 10, 2023 17:57
@kanpuriyanawab kanpuriyanawab deleted the bart-config branch March 10, 2023 17:57
@kanpuriyanawab
Copy link
Collaborator Author

Thanks @mattdangerw ! Just a gentle request that #754 and #794 need review !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call super.config() in BartBackbone's get_config()
2 participants
@kanpuriyanawab @mattdangerw