Make version number SSoT. #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to wait until we are ready to update a few things here. This will break the contributor guide, a lot of colabs, and the "run for source" instructions on this README and keras.io right? Can take a look next week probably. |
|
Sounds good, let's wait. |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
chenmoneygithub
pushed a commit
that referenced
this pull request
May 4, 2023
* Make version number SSoT. * Don't restrict "local installs" for now * reformat * Remove no longer needed version replacement --------- Co-authored-by: Matt Watson <mattdangerw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding redundancy in specifying the version number. Added benefit: it prevents folks from incorrectly using
setup.pyand points them towards the correct workflow.