Fix typo in position embedding docstring #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhadse
pushed a commit
to adhadse/keras-nlp
that referenced
this pull request
Sep 17, 2022
mattdangerw
added a commit
that referenced
this pull request
May 21, 2024
* Add a response_mask input * Improved attention logic to account for response mask (#87) * Improved attention logic to account for response mask * Addressed several comments * remove vit_num_classes arg from pali_gemma_backbone * fix backbone test * Try simplifying the masking code * Updated tests for thoroughness * Comments and one fix * update preset version * deleted test using unused code path * Added cast to solve bool issues * update presets path * code reformat# modified: keras_nlp/src/models/pali_gemma/pali_gemma_decoder_block_test.py * remove changes to backbone args --------- Co-authored-by: divyashreepathihalli <divyashreepathihalli@gmail.com> Co-authored-by: Matt Watson <mattdangerw@gmail.com> --------- Co-authored-by: Varun Singh <VarunS1997@users.noreply.github.com> Co-authored-by: divyashreepathihalli <divyashreepathihalli@gmail.com>
mattdangerw
added a commit
that referenced
this pull request
May 21, 2024
* Add a response_mask input * Improved attention logic to account for response mask (#87) * Improved attention logic to account for response mask * Addressed several comments * remove vit_num_classes arg from pali_gemma_backbone * fix backbone test * Try simplifying the masking code * Updated tests for thoroughness * Comments and one fix * update preset version * deleted test using unused code path * Added cast to solve bool issues * update presets path * code reformat# modified: keras_nlp/src/models/pali_gemma/pali_gemma_decoder_block_test.py * remove changes to backbone args --------- Co-authored-by: divyashreepathihalli <divyashreepathihalli@gmail.com> Co-authored-by: Matt Watson <mattdangerw@gmail.com> --------- Co-authored-by: Varun Singh <VarunS1997@users.noreply.github.com> Co-authored-by: divyashreepathihalli <divyashreepathihalli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.