Speeding the tests for whisper #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
requested changes
Mar 21, 2023
| with self.tpu_strategy.scope(): | ||
| self.model = WhisperBackbone( | ||
| self.backbone = WhisperBackbone( | ||
| vocabulary_size=1000, |
There was a problem hiding this comment.
let's size down this backbone same as above.
|
Hi @mattdangerw I made those changes that you requested. Please check |
|
LGTM! |
mattdangerw
approved these changes
Mar 22, 2023
kanpuriyanawab
pushed a commit
to kanpuriyanawab/keras-nlp
that referenced
this pull request
Mar 26, 2023
* modified tests for whisper * comments
kanpuriyanawab
pushed a commit
to kanpuriyanawab/keras-nlp
that referenced
this pull request
Mar 26, 2023
* modified tests for whisper * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies tests as described in #866 for
whisper.Results
before - 9 passed, 3 skipped in 22.53s
after - 8 passed, 4 skipped in 7.96s
2.83 times speedup(on my local machine)
@mattdangerw @chenmoneygithub