Skip to content

Conversation

Warlord-K
Copy link
Contributor

Partially fixes: #867

  • Make sure to update any "custom vocabulary" examples to match the model actual vocabulary type and special token requirements (varies per model).
  • Test out all docstring snippets!
    Gist of all docstring snippets.
  • Make sure to follow our code style guidelines re indentation etc.

@mattdangerw
Copy link
Member

Thanks! This looks great, just correcting A OPT -> An OPT as a merge.

@mattdangerw mattdangerw merged commit 36182e3 into keras-team:master Mar 21, 2023
kanpuriyanawab pushed a commit to kanpuriyanawab/keras-nlp that referenced this pull request Mar 26, 2023
…s-team#893)

* Custom vocab from true vocab

* Custom Vocab Changes reverted

* Minor docstring edit

---------

Co-authored-by: Matt Watson <1389937+mattdangerw@users.noreply.github.com>
kanpuriyanawab pushed a commit to kanpuriyanawab/keras-nlp that referenced this pull request Mar 26, 2023
…s-team#893)

* Custom vocab from true vocab

* Custom Vocab Changes reverted

* Minor docstring edit

---------

Co-authored-by: Matt Watson <1389937+mattdangerw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework model docstrings for progressive disclosure of complexity
2 participants