Init _backbone, _tokenizer and _preprocessor in Task
#899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbischof
changed the title
_backbone and _preprocessor in Task_backbone _tokenizer and _preprocessor in Task
jbischof
changed the title
_backbone _tokenizer and _preprocessor in Task_backbone, _tokenizer and _preprocessor in Task
mattdangerw
reviewed
Mar 22, 2023
kanpuriyanawab
pushed a commit
to kanpuriyanawab/keras-nlp
that referenced
this pull request
Mar 26, 2023
…m#899) * Init _backbone in Task * Fix `preprocessor` as well * format * Fix `_tokenizer` * Chain to super() first
kanpuriyanawab
pushed a commit
to kanpuriyanawab/keras-nlp
that referenced
this pull request
Mar 26, 2023
…m#899) * Init _backbone in Task * Fix `preprocessor` as well * format * Fix `_tokenizer` * Chain to super() first
chenmoneygithub
pushed a commit
to chenmoneygithub/keras-nlp
that referenced
this pull request
Mar 28, 2023
…m#899) * Init _backbone in Task * Fix `preprocessor` as well * format * Fix `_tokenizer` * Chain to super() first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an annoying corner case where the
backboneproperty references a_backboneattribute that itself is never initalized.Initializing this properly allows the base class to set
self.backbone = Noneby default as intended instead of throwing anAttributeError.We do the same for
preprocessorandtokenizer.