Possible fix for task.summary() #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
force-pushed
the
task-summaries
branch
2 times, most recently
from
881cfdc to
4515ea0
Compare
|
Talk with @fchollet, think we should go for something like this (almost any fix will be a positive delta). Added some tests and marking this ready for review! |
fchollet
approved these changes
Mar 22, 2023
| ) | ||
|
|
||
|
|
||
| def print_msg(message, line_break=True): |
There was a problem hiding this comment.
I wonder if we should export these 2 to internal so our other packages can use them?
There was a problem hiding this comment.
I think we would probably still need to copy for now, as we wouldn't want the dep on tf 2.13 anytime soon.
But could be worth thinking about this yeah. Is custom summaries a need for CV or any other keras ecosystem project?
mattdangerw
force-pushed
the
task-summaries
branch
from
4515ea0 to
07aeb0e
Compare
Make sure model summaries are reportable by the model as soon as they are created, and include a section for preprocessing on the task, if a task has preprocessing.
mattdangerw
force-pushed
the
task-summaries
branch
from
07aeb0e to
d6b380e
Compare
jbischof
approved these changes
Mar 23, 2023
kanpuriyanawab
pushed a commit
to kanpuriyanawab/keras-nlp
that referenced
this pull request
Mar 26, 2023
Make sure model summaries are reportable by the model as soon as they are created, and include a section for preprocessing on the task, if a task has preprocessing.
kanpuriyanawab
pushed a commit
to kanpuriyanawab/keras-nlp
that referenced
this pull request
Mar 26, 2023
Make sure model summaries are reportable by the model as soon as they are created, and include a section for preprocessing on the task, if a task has preprocessing.
chenmoneygithub
pushed a commit
to chenmoneygithub/keras-nlp
that referenced
this pull request
Mar 28, 2023
Make sure model summaries are reportable by the model as soon as they are created, and include a section for preprocessing on the task, if a task has preprocessing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #898.
demo colab