Roberta docstring reworking #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenmoneygithub
suggested changes
Mar 29, 2023
| [" afternoon sun", " night moon"] | ||
| preprocessor("The quick b rown fox jumped.") | ||
| # Tokenize a batch of single sentences . |
There was a problem hiding this comment.
nit: remove space between sentences and period.
| preprocessor(["The quick brown fox jumped.", "Call me Ishmael."]) | ||
| # Preprocess a batch of sentence pairs. | ||
| # When handling multiple sequences, always convert to tensors first ! |
There was a problem hiding this comment.
same, remove the extra space
| it should be the file path to merge rules. The merge rule file | ||
| should have one merge rule per line. Every merge rule contains | ||
| merge entities separated by a space. | ||
| vocabulary: A dictionary or a string filename path. If passing a |
There was a problem hiding this comment.
Suggested edit:
A dictionary mapping tokens to integer ids, or file path to a json file containing the token to id mapping.
| vocabulary: A dictionary or a string filename path. If passing a | ||
| filename, the file should be a json file. both json and dictionary | ||
| should map a single word piece token string to an integer id. | ||
| merges: A list of merge rules or a string filename path, If passing a |
There was a problem hiding this comment.
nit: filename path => file path, and use "." to replace ","
chenmoneygithub
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#867
link to colab used for testing: https://colab.research.google.com/drive/1TR4dCo_15IOaMdWZq1rrYcK4mscW5ACS#scrollTo=Iy8I5mZpYeMz