Don't save traces for saved model #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
mattdangerw
force-pushed
the
no-trace-saving
branch
2 times, most recently
from
bbafd36 to
7f754c9
Compare
|
/gcbrun |
| # Check that output matches. | ||
| restored_output = restored_model.predict(self.raw_batch) | ||
| self.assertAllClose(model_output, restored_output) | ||
| self.assertAllClose(model_output, restored_output, atol=0.01, rtol=0.01) |
There was a problem hiding this comment.
Curious - why would it fluctuate? 0.01 without context is not a common scale in atol.
There was a problem hiding this comment.
I'm not really sure, also this is totally unrelated, so I can split into a separate PR. I was seeing enough fluctuation on my nvidia GPU that sometimes these tests would fail. This is true on master too.
It looks like it is just a precision issue, the floats are the same, with a lax enough tolerance.
mattdangerw
force-pushed
the
no-trace-saving
branch
from
7f754c9 to
23df696
Compare
|
/gcbrun |
chenmoneygithub
approved these changes
Mar 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check compilation elsewhere, adding this option significantly speeds up saved model testing. Roughly 3x for the tf format.