Skip to content

Conversation

haifeng-jin
Copy link
Contributor

@haifeng-jin haifeng-jin commented Apr 12, 2023

  • Update the setup for devcontainers (GitHub Codespaces).
    • Use Codespaces official base images for standard setups.
    • Added the required plugins, especially the gh CLI.
    • Enable autoformat on save.
    • Fixed the dependency installs.
  • Extract the config of isort and black to pyproject.toml so that the behavior is more consistent when running the commands by different means.
  • Change the flake8 to behave consistently in setup.cfg, lint.sh, and format.sh. It use to have 80 char line length in setup.cfg, which would confuse the IDEs. The actual line-length is 200. Ideally, we should just use 80 and comment the long lines with # noqa: E501. If we want this, I can file an issue and call for community help.

@haifeng-jin haifeng-jin marked this pull request as ready for review April 12, 2023 17:49
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And nice having you over on the NLP side :)

Just some style nits.

@haifeng-jin haifeng-jin requested a review from mattdangerw April 12, 2023 20:51
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattdangerw mattdangerw merged commit f82d3d5 into keras-team:master Apr 12, 2023
@haifeng-jin haifeng-jin deleted the docker branch April 12, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants