Skip to content

Added KerasTuner Hyper-Parameter Search for the BERT fine-tuning script. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 3, 2022
Merged

Added KerasTuner Hyper-Parameter Search for the BERT fine-tuning script. #143

merged 19 commits into from
May 3, 2022

Conversation

Stealth-py
Copy link
Contributor

Fixes #114
This PR is open for review!

mattdangerw
mattdangerw requested changes Apr 26, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good! Left a few comments.

@mattdangerw mattdangerw requested a review from haifeng-jin April 26, 2022 18:52
chenmoneygithub
chenmoneygithub reviewed Apr 26, 2022
View reviewed changes
haifeng-jin
haifeng-jin reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Stealth-py
Copy link
Contributor Author

Stealth-py commented Apr 26, 2022 •
edited
Loading

Thank you for the reviews! I've made the appropriate changes.
Regarding this I've changed it to val_loss for now.

chenmoneygithub
chenmoneygithub reviewed Apr 28, 2022
View reviewed changes
mattdangerw
mattdangerw reviewed Apr 28, 2022
View reviewed changes
mattdangerw
mattdangerw reviewed Apr 28, 2022
View reviewed changes
mattdangerw
mattdangerw reviewed Apr 28, 2022
View reviewed changes
@Stealth-py
Copy link
Contributor Author

Thank you for the reviews! I've resolved most of them, have a few doubts in the couple unresolved conversations above.

chenmoneygithub
chenmoneygithub approved these changes May 2, 2022
View reviewed changes
@mattdangerw
Copy link
Member

@Stealth-py thanks! Replied above. This overall is looking great, but I think we need to resolve the "re-training" question before we land this.

@haifeng-jin haifeng-jin mentioned this pull request May 3, 2022
Open
@Stealth-py
Copy link
Contributor Author

Stealth-py commented May 3, 2022 •
edited
Loading

@mattdangerw I've made the final changes in the last commit! I hope this is fine.

mattdangerw
mattdangerw approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for all the work on this.

This will be a good model for hyper parameter search for fine tuning in general, which is something we will likely need to do a lot of.

@mattdangerw mattdangerw merged commit 68eb2f7 into keras-team:master May 3, 2022
@Stealth-py Stealth-py deleted the kerastuner-hyperparameter-search branch May 3, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

+2 more reviewers

@haifeng-jin haifeng-jin haifeng-jin left review comments

@chenmoneygithub chenmoneygithub chenmoneygithub approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use KerasTuner to hyper-parameter search for the BERT finetuning script
4 participants
@Stealth-py @mattdangerw @haifeng-jin @chenmoneygithub