Handle OOV token in XLMRoBERTaTokenizer's token_to_id function #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
reviewed
Apr 7, 2023
| """Convert a string token to an integer id.""" | ||
|
|
||
| # OOV token | ||
| if token not in self.get_vocabulary(): |
There was a problem hiding this comment.
Does sentencepiece not handle the oov token in this case? If we can just remap the output that would be better.
This would require loading the full vocab list into a python list and then iterating over it in its entirety. That's probably quite slow!
mattdangerw
reviewed
Apr 7, 2023
| return self._vocabulary_prefix.index(token) | ||
|
|
||
| return int(self._sentence_piece.string_to_id(token).numpy()) + 1 | ||
| spm_token_id = int(self._sentence_piece.string_to_id(token).numpy()) |
There was a problem hiding this comment.
let's compare in tensor space, convert to int at the end?
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.