Skip to content

Refactoring: Simplified some code by using the to_list function. #10678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2018
Merged

Refactoring: Simplified some code by using the to_list function. #10678

merged 2 commits into from
Jul 26, 2018

Conversation

gabrieldemarmiesse
Copy link
Contributor

Summary

We have the method to_list in keras. Let's use it to make the codebase simpler!

Related Issues

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Dref360
Dref360 approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@Dref360 Dref360 merged commit dd07a4c into keras-team:master Jul 26, 2018
@gabrieldemarmiesse gabrieldemarmiesse deleted the simplifying_methods branch September 18, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Dref360 Dref360 Dref360 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrieldemarmiesse @Dref360