Skip to content

Conversation

james77777778
Copy link
Contributor

Related to keras-team/keras-hub#1670
The logic could be further simplified if we could call super().quantize in subclasses.

A minor simplification in the tests for quantization is also included.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (d910dcb) to head (27740b6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19949   +/-   ##
=======================================
  Coverage   79.07%   79.08%           
=======================================
  Files         499      499           
  Lines       46726    46732    +6     
  Branches     8617     8620    +3     
=======================================
+ Hits        36950    36956    +6     
  Misses       8043     8043           
  Partials     1733     1733           
Flag Coverage Δ
keras 78.93% <100.00%> (+<0.01%) ⬆️
keras-jax 62.27% <100.00%> (+<0.01%) ⬆️
keras-numpy 57.29% <91.66%> (+<0.01%) ⬆️
keras-tensorflow 63.56% <100.00%> (+<0.01%) ⬆️
keras-torch 62.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 3, 2024
@fchollet fchollet merged commit ca9519b into keras-team:master Jul 3, 2024
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Jul 3, 2024
@james77777778 james77777778 deleted the improve-quantize branch July 4, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants