Update user profile #293
Merged
Update user profile #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenySadadia
removed
the
staging-skip
Merged
|
@JenySadadia Please rebase |
Implement endpoint PUT `/user/profile/{username}` to
update user profile details. The user can update
password, and user groups using the PUT request.
User will not be allowed to add oneself to `admin`
user group.
Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
gctucker
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
The commit title seems to imply that the user profile model is being updated, rather than it's implementing an endpoint for updating user profile documents. But that's a detail, just maybe something to keep in mind in the future to always try and be accurate in git commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PUT
/user/profile/{username}endpoint to update user profiles.