Assign ownership details to a hierarchy of nodes #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 13, 2023 16:16
Create a separate model to store user information that will be accessible publicly and can be updated by user. Store private information along with profile to `User` model and only admins will be allowed to access/update it. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
`User` model has been restructured to have a user public profile in `User.profile` field. Use the field for the related changes in Authentication module. Authentication method `get_current_user` will need to get `User` object based on `profile`. For that, implement `Database.find_one_by_attributes` method to find user object matching username from user profile. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Update `post_user` handler to create user profile object and use it to create user object. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Update `post_node` handler to use user profile to get node owner's username. This change is due to restructuring user model with `UserProfile`. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Update unit tests to accommodate changes in the `User` field related to user profile. Also, add mock function for `Database.find_one_by_attributes` and use it for token handler tests. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Update `authorize_user` method to use user profile to get node owner's username and groups. This change is due to restructuring user model with `UserProfile`. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Update e2e tests to accommodate changes in the `User` field related to user profile. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Update `setup_admin_user` method to use user profile to while creating admin user. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
When submitting a hierarchy of nodes using `put_nodes`, set node ownership information to all the nodes recursively. Also, use `authorize_user` method for user authorization upon receiving the request. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
gctucker
reviewed
Jul 17, 2023
Please see below line of change. It needs to have |
|
Ah yes, thanks. Well if we don't have the UserProfile changes then we can just do |
gctucker
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #292 for user profile changes.
api.main: set node ownership to a hierarchy of nodes
When submitting a hierarchy of nodes using
put_nodes, set node ownership information to all the nodes recursively.Also, use the
authorize_usermethod for user authorization upon receiving the request.