-
Notifications
You must be signed in to change notification settings - Fork 21
api.db: enable boolean query fields for GET requests #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested OK on staging:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - some minor comments.
78ef5c0
to
19c893d
Compare
Enable support for querying boolean fields while getting objects from API such as nodes or models. e.g. find all the active admin users using `http://API_SERVER/users?is_active=true&is_superuser=true` Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Instead of using integer values 1 and 0 for `User` model boolean fields, use `True` and `False` to enable querying boolean fields in MongoDB as per the syntax. Fixes: 310f3d6 ("migration: add migration for user documents") Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
19c893d
to
54008c5
Compare
Thanks for the updates, LGTM now. I haven't tested it so not approving yet. |
LGTM, tested by curl.
|
Works for me:
|
You are right, sorry for noise, kci was pointing to wrong instance, my mistake. |
Fixes #390
Fixes #410
Enable support for querying boolean fields while getting objects from API such as nodes or models.
e.g. find all the active admin users using
http://API_SERVER/users?is_active=true&is_superuser=true