Skip to content

kernelci: config: reduce noise during config parsing #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

kernelci: config: reduce noise during config parsing #2989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions kernelci/config/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,15 @@ def _format_dict_strings(param, fmap):
if isinstance(param, str):
try:
param = param.format_map(fmap)
except (KeyError, ValueError) as exc:
print(f"Format string error in param '{param}': {exc}")
# Upon loading the config files, we go through lots of fields (e.g. `nfsroot`)
# that contain unresolved params (such as `debarch` or `kver`) as we're not
# processing a job yet. In such cases, format_map() returns a KeyError we can
# just ignore.
except KeyError:
return param # Don't do anything but keep python happy
except ValueError as exc:
print(f"Format string error in param '{param}': {exc}")
return param # Return the unformatted param, this will help spot the error
elif isinstance(param, dict):
for key in param:
param[key] = _format_dict_strings(param[key], fmap)
Expand Down