-
Notifications
You must be signed in to change notification settings - Fork 497
Reduce vivisect.base and vivisect.impemu cape-processor logs #2665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce vivisect.base and vivisect.impemu cape-processor logs #2665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ChrisThibodeaux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue where cape-processor
logs were excessively flooded with messages from vivisect
. The primary goal is to significantly reduce the volume of these logs by adjusting the logging levels for specific vivisect
components. This change aims to make the logs more manageable and focus on relevant information by suppressing less critical messages from vivisect.base
and vivisect.impemu
.
Highlights
- Logging Configuration Update: The logging levels for
vivisect
,vivisect.base
, andvivisect.impemu
have been adjusted inlib/cuckoo/common/integrations/capa.py
to reduce the verbosity of logs. Specifically,vivisect
is now set toINFO
, whilevivisect.base
andvivisect.impemu
are set toERROR
to filter out less critical messages.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively reduces the verbosity of logs from vivisect
by adjusting the logging levels for its various components. The changes are in line with the stated goal of keeping relevant logs while suppressing less critical ones. I have one minor suggestion to update a comment to ensure it accurately reflects the new behavior, which will improve the code's maintainability.
02052bd
to
0a56872
Compare
interesting, i had disable it completely |
I found that the current settings had no impact on logs at |
I can definitely make that change, not a problem. I found some of the
However, leaving it at I agree on the swap to |
0a56872
to
915ae22
Compare
we can mute per subparsers if we want that is not a big problem. so maybe we should add |
No problem, I will test that out today |
ce5dd8c
to
b8a6e04
Compare
Thank you |
Cape-processor logs are flooded with vivisect logs. These changes keep relevant
vivisect
logs and removevivisect.base
andvivisect.impemu
logs below theERROR
level.