Skip to content

Conversation

ChrisThibodeaux
Copy link
Contributor

Cape-processor logs are flooded with vivisect logs. These changes keep relevant vivisect logs and remove vivisect.base and vivisect.impemu logs below the ERROR level.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ChrisThibodeaux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where cape-processor logs were excessively flooded with messages from vivisect. The primary goal is to significantly reduce the volume of these logs by adjusting the logging levels for specific vivisect components. This change aims to make the logs more manageable and focus on relevant information by suppressing less critical messages from vivisect.base and vivisect.impemu.

Highlights

  • Logging Configuration Update: The logging levels for vivisect, vivisect.base, and vivisect.impemu have been adjusted in lib/cuckoo/common/integrations/capa.py to reduce the verbosity of logs. Specifically, vivisect is now set to INFO, while vivisect.base and vivisect.impemu are set to ERROR to filter out less critical messages.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reduces the verbosity of logs from vivisect by adjusting the logging levels for its various components. The changes are in line with the stated goal of keeping relevant logs while suppressing less critical ones. I have one minor suggestion to update a comment to ensure it accurately reflects the new behavior, which will improve the code's maintainability.

@doomedraven
Copy link
Collaborator

interesting, i had disable it completely

@ChrisThibodeaux
Copy link
Contributor Author

ChrisThibodeaux commented Aug 11, 2025

I found that the current settings had no impact on logs at INFO level or above. I'm not entirely sure how NOTSET works, but it seems to use a lower-heirarchy logger's level to set the one in capa.py

@doomedraven
Copy link
Collaborator

Captura de pantalla 2025-08-11 a las 23 22 05

maybe better to set it to critical?

@ChrisThibodeaux
Copy link
Contributor Author

I can definitely make that change, not a problem.

I found some of the [vivisect] logs to be useful, such as:

2025-08-11 15:39:37,257 [Task 894] [vivisect] INFO: Percentage of discovered executable surface area: 95.8% (427791 / 446464)
2025-08-11 15:39:37,257 [Task 894] [vivisect] INFO:    Xrefs/Blocks/Funcs:                             (31491 / 23131 / 1610)
2025-08-11 15:39:37,257 [Task 894] [vivisect] INFO:    Locs,  Ops/Strings/Unicode/Nums/Ptrs/Vtables:   (89714:  83169 / 623 / 782 / 1339 / 620 / 0)

However, leaving it at INFO does still output more logs than are useful. Particularly, vivisect.parsers.pe is still a pain and really overkill with logging..

I agree on the swap to CRITICAL and have tested it locally.

@doomedraven
Copy link
Collaborator

doomedraven commented Aug 12, 2025

we can mute per subparsers if we want that is not a big problem. so maybe we should add logging.getLogger("vivisect.parsers.pe").setLevel(logging.CRITICAL) ? could you test it please

@ChrisThibodeaux
Copy link
Contributor Author

No problem, I will test that out today

@doomedraven
Copy link
Collaborator

Thank you

@doomedraven doomedraven merged commit c4257e1 into kevoreilly:master Aug 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants