Skip to content

Conversation

ChrisThibodeaux
Copy link
Contributor

@ChrisThibodeaux ChrisThibodeaux commented Aug 12, 2025

Replace the leftover code spots pointing to /usr/bin/7z.

@doomedraven
My preferred fix:

  1. Set 7zz binary relative location in only one place in one config file.
  2. Create a constant using SEVENZIP_BIN = os.path.join(CUCKOO_ROOT, <config_value>) that can be imported where needed.

Let me know if I should do that instead and I will make the changes to this PR.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ChrisThibodeaux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates all references to the 7-Zip (7zz) binary location from the system-wide /usr/bin/7z to a relative path within the application's data/7zz directory. This ensures consistency and proper discovery of the 7zz executable across various configurations and Python modules.

Highlights

  • Configuration Updates: Modified processing.conf.default and reporting.conf.default to point the 7-Zip binary path to data/7zz.
  • Python Code Adjustments: Updated lib/cuckoo/common/integrations/file_extra_info.py to use os.path.join(CUCKOO_ROOT, "data/7zz") for the 7-Zip binary path and adjusted related comments and command execution.
  • Processing Module Fix: Corrected the hardcoded path in a comment and the command string within modules/processing/suricata.py to reflect the new data/7zz location.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the path for the 7zip binary across configuration files and Python scripts, replacing hardcoded paths with a path relative to the application's root. The changes are mostly correct and improve the portability of the application.

However, I've found an issue in modules/processing/suricata.py where the updated relative path for the 7zip binary is used in a way that will cause an error at runtime. I've left a comment with details on the issue and a suggestion for a fix.

@ChrisThibodeaux ChrisThibodeaux force-pushed the sevenzip-binary-location-updates branch from 2fe2747 to 8506d2d Compare August 12, 2025 04:46
@doomedraven doomedraven merged commit 0b63105 into kevoreilly:master Aug 12, 2025
3 checks passed
@doomedraven
Copy link
Collaborator

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants