Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reactive Keycloak-X Admin Client #9539

Closed
Tracked by #10708
sberyozkin opened this issue Jan 12, 2022 · 4 comments · Fixed by #10714
Closed
Tracked by #10708

Add Reactive Keycloak-X Admin Client #9539

sberyozkin opened this issue Jan 12, 2022 · 4 comments · Fixed by #10714
Labels
kind/feature Categorizes a PR related to a new feature
Milestone
17.0.1

Comments

@sberyozkin
Copy link

sberyozkin commented Jan 12, 2022 •
edited
Loading

Description

Keycloak Admin Client currently depends on the blocking RESTEasy Client which makes it impossible to use it with Quarkus RESTEasy Reactive server or client extensions.

Adding a Reactive Admin Client in Keycloak-X which will depend on Quarkus Rest Client Reactive extension will resolve the problem

Discussion

No response

Motivation

No response

Details

No response
@sberyozkin sberyozkin added kind/feature Categorizes a PR related to a new feature status/triage labels Jan 12, 2022
@geoand
Copy link
Contributor

geoand commented Jan 12, 2022

Or maybe have some kind of artifact that simply defines the interfaces?

@sberyozkin sberyozkin mentioned this issue Mar 7, 2022
Closed
@pedroigor
Copy link
Contributor

I also think that is the best way to go, mainly because the library should work for Wildfly too.

The main issue here should be related to how we create Keycloak instances and the root JAX-RS client resource from where the others are obtained.

We should be able to leverage the existing JAX-RS client resources, right? Or do you expect changes in their definitions in order to work with RESTEasy Reactive Client?

@pedroigor pedroigor mentioned this issue Mar 11, 2022
Merged
@pedroigor
Copy link
Contributor

@sberyozkin @geoand Sent #10714 as the first step to enable using different JAX-RS Client implementations.

It does not touch yet the JAX-RS client resources and some are still using RESTEasy specific APIs.

@geoand
Copy link
Contributor

geoand commented Mar 11, 2022

👍🏼

pedroigor added a commit to pedroigor/keycloak that referenced this issue Mar 14, 2022
@pedroigor
Support for running the client using different JAX-RS Client implemen…
960a330 
…tations

Fixes keycloak#9539
pedroigor added a commit to pedroigor/keycloak that referenced this issue Mar 14, 2022
@pedroigor @geoand
Support for running the client using different JAX-RS Client implemen…
3edc69b 
…tations

Closes keycloak#9539

Co-authored-by: geoand <geoand@gmail.com>
@pedroigor pedroigor added this to the 17.0.1 milestone Mar 15, 2022
@pedroigor pedroigor mentioned this issue Mar 15, 2022
Closed
13 tasks
Repository owner moved this from Ready to Done in Keycloak: Quarkus distribution Mar 16, 2022
pedroigor added a commit that referenced this issue Mar 16, 2022
@pedroigor @geoand
Support for running the client using different JAX-RS Client implemen…
53bbf30 
…tations

Closes #9539

Co-authored-by: geoand <geoand@gmail.com>
@pedroigor pedroigor mentioned this issue Mar 21, 2022
Merged
pedroigor added a commit to pedroigor/keycloak that referenced this issue Mar 21, 2022
@pedroigor @geoand
Support for running the client using different JAX-RS Client implemen…
84de154 
…tations

Closes keycloak#9539

Co-authored-by: geoand <geoand@gmail.com>
stianst pushed a commit that referenced this issue Mar 21, 2022
@pedroigor @geoand
Support for running the client using different JAX-RS Client implemen…
252adf2 
…tations (#10844)

Closes #9539

Co-authored-by: geoand <geoand@gmail.com>

Co-authored-by: geoand <geoand@gmail.com>
@tuniemela tuniemela mentioned this issue Mar 23, 2022
Merged
@hongquyen196 hongquyen196 mentioned this issue May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes a PR related to a new feature
Projects
Keycloak: Quarkus distribution
Status: Done
Milestone
17.0.1
Development

Successfully merging a pull request may close this issue.

Support for running the client using different JAX-RS Client implementations pedroigor/keycloak
4 participants
@sberyozkin @pedroigor @stianst @geoand