Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infrastructure] Update packages to use the follow-keyboard-version flag #246

Closed
darcywong00 opened this issue Apr 28, 2018 · 4 comments · Fixed by #410
Closed

[infrastructure] Update packages to use the follow-keyboard-version flag #246

darcywong00 opened this issue Apr 28, 2018 · 4 comments · Fixed by #410

Comments

@darcywong00
Copy link
Contributor

darcywong00 commented Apr 28, 2018

  • Update compiler to 10.0.981.0 or later for fkv support
  • Update keyboards to use FKV flag (or do we use this on an as-needed basis?)

(edit) Current kmcomp is already later than 10.0.981.0

@darcywong00 darcywong00 added this to the P3S2 milestone Apr 28, 2018
darcywong00 added a commit to darcywong00/keyboards that referenced this issue Apr 28, 2018
@mcdurdin mcdurdin modified the milestones: P3S2, P3S3 May 4, 2018
@mcdurdin mcdurdin modified the milestones: P3S3, P3S4 May 18, 2018
@mcdurdin mcdurdin modified the milestones: P3S4, P3S5 Jun 4, 2018
@darcywong00
Copy link
Contributor Author

@DavidLRowe and @LornaSIL can you clarify which keyboard packages in the repo should not get this flag?
<FollowKeyboardVersion/>

@LornaSIL
Copy link
Contributor

LornaSIL commented Jun 8, 2018 via email

@DavidLRowe
Copy link
Contributor

Most of the keyboards in the release folder are updated by PR #407 . See that PR for several odd cases.

@LornaSIL
Copy link
Contributor

Still need to fix:

  • gff_ethiopic_7 (should let @dyacob to fix)
    • gff_ethiopic_7/source/gff_ethiopic_7.kps has version "1.0" and no FKVflag, but gff_ethiopic_7/source/gff_ethiopic_7.kmn contains no &keyboardversion statement -- seems as though the .kmn needs to be updated to have a version number before the FKVflag can be set (or is the default version number 1.0?).
  • sil_tchad (but Jeff H wants to update it, so should we wait?)
    • sil_tchad/source/sil_tchad.kps has version "3.3.1" and FKVflag set, but sil_tchad/source/sil_tchad.kmn has "store(&KEYBOARDVERSION) '3.3' " -- seems as though the version in the .kmn file needs updating.

The powerpacks will be deprecated so it's probably okay not to update them:

  • release/packages/gff_amh_powerpack_7/source/gff_amh_powerpack_7.kps -- has multiple keyboards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants