Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gff_amharic] Update to v1.5 #302

Merged
merged 61 commits into from
Jun 4, 2018
Merged

[gff_amharic] Update to v1.5 #302

merged 61 commits into from
Jun 4, 2018

Conversation

dyacob
Copy link
Contributor

@dyacob dyacob commented May 23, 2018

his is the successor to the gff_amh_7 keyboard. Primarily the help documentation has changed to sync with updates made to companion keyboards in 2017. The only key sequence to change will be # (hash mark) before numerals in place of ' (apostrophe) which should be more intuitive and avoids conflicts with "smart quotes" in current day word processors.

@LornaSIL
Copy link
Contributor

LornaSIL commented May 31, 2018

  • The Welcome.htm file needs renaming to welcome.htm. Apparently the uppercase can cause problems on Linux perhaps. After renaming make sure it's still loading in .kps.
    • I would still like to see the welcome.htm title include the keyboard name if possible አማርኛ (Amharic)
  • There is still a .docx file referenced in the .kps. Can you delete that? Marc said it's okay to be in the repo, but not in the package. I don't see it in the .kpj, so it's not actually in the built package, and I'm not sure how that is happening.
  • The .kvks file still seems to be binary rather than .xml.
  • The readme.htm still say "The contents of this package contain both free (OpenSource) and commercial software from various organizations." Is that still true or is everything OpenSource now? I guess some of the fonts are "commercial" but are free. Is that right?
  • If you don't need the "extras" folder you could delete it.

@mcdurdin mcdurdin modified the milestones: P3S4, P3S5 Jun 4, 2018
@dyacob
Copy link
Contributor Author

dyacob commented Jun 4, 2018

@LornaSIL regarding the "extras" folder -I really don't know what its about so I was hesitant to remove it. Someone else has added it. I see files there that look as though they might support the keyboard for touch screens. I believe it would be safe to remove the folder since the contents are applicable to the previous version (gff_amh_7) and have not been tested with the current. If needed later they can be retrieved from the older version.

@dyacob
Copy link
Contributor Author

dyacob commented Jun 4, 2018

@LornaSIL, I believe all changes are in, I made a title change to:

The Ge’ez Frontier Foundation Keyboard for Amharic (አማርኛ ) Language

but could change it to the following if its closer to what you have in mind:

The Ge’ez Frontier Foundation አማርኛ (Amharic) Keyboard

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit 5914d06 into keymanapp:master Jun 4, 2018
@LornaSIL
Copy link
Contributor

LornaSIL commented Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants