Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[el_dinka] Added cross platform support #388

Merged
merged 8 commits into from
Jul 6, 2018
Merged

Conversation

andjc
Copy link
Contributor

@andjc andjc commented Jul 6, 2018

version 3.0 of layout, cross platform.

@LornaSIL
Copy link
Contributor

LornaSIL commented Jul 6, 2018

  • Consider changing name in README.md (from "Dinka Basic (DLIA)" to "Thuɔŋjäŋ"
  • Consider changing name in HISTORY.md (from "Dinka" to "Thuɔŋjäŋ"
  • On the mobile layout (phone):
    • Shift "O" - the double OO with diaeresis is not being output
    • Shift "A" - the double AA with diaeresis is not being output
    • Shift "X" (open o) - the 2nd open o is outputting an epsilon with diaeresis (instead of open o) and the double open o is outputting two epsilons with diaeresis (not double open o with epsilon)
    • numeric layer, the " key is outputing | (long press keys are outputting correctly)
    • numeric layer, the ' key is outputing \ (long press keys are outputting correctly)

I can't test the tablet tonight, but it's possible the same errors on the phone are happening on the tablet. I'll check tomorrow.

Desktop keyboard seems to work well. I like the shift backspace idea and the double vowels on the mobile longpress is a nice idea.

@LornaSIL
Copy link
Contributor

LornaSIL commented Jul 6, 2018

The things I reported last night are fixed.

On the tablet layer there is a key for combining underline, but it doesn't produce anything and you don't use that in the Desktop or phone layout. Is that a remnant from another keyboard? I think it needs removing from both default and shift layers.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants