-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): Fixed duplicate Google Logo UI fix #450
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are files which are not related to the change you mentioned, so those won't be committed, these files are packages/secret-scan/src/rules
and web/src/app/(main)/career
, after these proposed fix we can merge this
This reverts commit 9b37973.
Reverted the changes done in the commit "codebase indentation fix" which affected some unnecessary files like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [2.6.0](v2.5.0...v2.6.0) (2024-10-24) ### 🚀 Features * **api:** Add icon and remove description field from workspace ([#435](#435)) ([a99c0db](a99c0db)) * **api-client:** Added workspace-membership and related tests ([#452](#452)) ([6a1c091](6a1c091)) * **api-client:** Create controller for User module ([#484](#484)) ([f9d8e83](f9d8e83)) * **api:** Add prod env schema in env file ([#436](#436)) ([21c3004](21c3004)) * **api:** Add resend otp implementation ([#445](#445)) ([4dc6aa1](4dc6aa1)) * **api:** Fetch total count of environments, [secure]s and variables in project ([#434](#434)) ([0c9e50a](0c9e50a)) * **api:** Replace `projectId` with `name` and `slug` in workspace-role response. ([#432](#432)) ([af06071](af06071)) * **cli:** Add functionality to operate on Secrets ([#504](#504)) ([1b4bf2f](1b4bf2f)) * **cli:** Add project command ([#451](#451)) ([70448e1](70448e1)) * **cli:** Add workspace operations ([#441](#441)) ([ed38d22](ed38d22)) * **cli:** implement commands to get, list, update, and delete, workspace roles ([#469](#469)) ([957ea8d](957ea8d)) * **cli:** Implemented pagination support ([#453](#453)) ([feb1806](feb1806)) * **cli:** Secret scan ([#438](#438)) ([85cb8ab](85cb8ab)) * **cli:** Update environment command outputs ([f4af874](f4af874)) * **platform:** Clearing email field after waitlisting the user email ([#481](#481)) ([256d659](256d659)) * Remove project IDs from workspace role export data and update tests ([#448](#448)) ([8fdb328](8fdb328)) * **web:** Configured extra check for waitlisted users already in the list and created toast message for them ([#492](#492)) ([2ddd0ef](2ddd0ef)) * **web:** show the toast only when email add successfully ([#490](#490)) ([783c411](783c411)) ### 🐛 Bug Fixes * **api,api-client:** Add environmentSlug in multiple places across the variable module ([#468](#468)) ([d970aff](d970aff)) * **api:** Replace the id with slug in the global-search service ([#455](#455)) ([74804b1](74804b1)) * **platform:** Fixed duplicate Google Logo UI fix ([#450](#450)) ([fb0d6f7](fb0d6f7)) * resolve footer website name cut-off or overlap issue ([#444](#444)) ([fe03ba2](fe03ba2)) * **web:** Horizontal Scrolling issue on the website ([#440](#440)) ([655177b](655177b)) ### 📚 Documentation * Add documentation for environment in CLI ([#462](#462)) ([dad7394](dad7394)) * Add documentation for project in CLI ([#466](#466)) ([341fb32](341fb32)) * Add documentation for scan in CLI ([#461](#461)) ([72281e6](72281e6)) * Add documentation for workspace command ([#464](#464)) ([4aad8a2](4aad8a2)) * Add instructions for resetting the local Prisma database ([#495](#495)) ([#501](#501)) ([b07ea17](b07ea17)) * Added docker support documentation ([#465](#465)) ([bc04be4](bc04be4)) * Added documentation for running the platform ([#473](#473)) ([8b8386b](8b8386b)) * Added missing mappings to pages ([5de9fd8](5de9fd8)) * Fix Documentation Hyperlink and update expired Discord invite link ([#496](#496)) ([5a10e39](5a10e39)) * Updated CLI docs ([#460](#460)) ([c7e0f13](c7e0f13)) ### 🔧 Miscellaneous Chores * Add more logging to Sentry init ([#470](#470)) ([de4925d](de4925d)) * **api:** Optimise API docker image size ([#360](#360)) ([ea40dc1](ea40dc1)) * **api:** Updated lockfile ([a968e78](a968e78)) * **CI:** Add [secure] scan validation ([f441262](f441262)) * **cli:** Update controller invocation in environment commands ([#477](#477)) ([596bd1a](596bd1a)) * Minor changes to variables ([fe01ca6](fe01ca6)) * **[secure]-scan:** Failing lint issues ([#507](#507)) ([48f45df](48f45df)) * **[secure]-scan:** Formatted files ([5884833](5884833)) * Update .env.example ([70ad4f7](70ad4f7)) * Updated scripts ([9eb76a7](9eb76a7)) * **web:** email validation ([#487](#487)) ([e8e737a](e8e737a))
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
User description
Description
Added Gitlab logo
Fixes #449
Dependencies
NA
Future Improvements
Linking to the Backend and if i get the figma file , i can add more features !
Mentions
@rajdip-b
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement, Other
Description
GitlabSVG
.GitlabSVG
from the auth SVG index.Changes walkthrough 📝
50 files
grafana.ts
Code formatting and consistency improvements in Grafana rules.
packages/secret-scan/src/rules/grafana.ts
authress.ts
Code formatting and consistency improvements in Authress rules.
packages/secret-scan/src/rules/authress.ts
cloudflare.ts
Code formatting and consistency improvements in Cloudflare rules.
packages/secret-scan/src/rules/cloudflare.ts
bitbucket.ts
Code formatting and consistency improvements in Bitbucket rules.
packages/secret-scan/src/rules/bitbucket.ts
facebook.ts
Code formatting and consistency improvements in Facebook rules.
packages/secret-scan/src/rules/facebook.ts
confluent.ts
Code formatting and consistency improvements in Confluent rules.
packages/secret-scan/src/rules/confluent.ts
atlassian.ts
Code formatting and consistency improvements in Atlassian rules.
packages/secret-scan/src/rules/atlassian.ts
shopify.ts
Code formatting and consistency improvements in Shopify rules.
packages/secret-scan/src/rules/shopify.ts
harness.ts
Code formatting and consistency improvements in Harness rules.
packages/secret-scan/src/rules/harness.ts
planetscale.ts
Code formatting and consistency improvements in Planetscale rules.
packages/secret-scan/src/rules/planetscale.ts
dropbox.ts
Code formatting and consistency improvements in Dropbox rules.
packages/secret-scan/src/rules/dropbox.ts
dynatrace.ts
Code formatting and consistency improvements in Dynatrace rules.
packages/secret-scan/src/rules/dynatrace.ts
digitalocean.ts
Code formatting and consistency improvements in DigitalOcean rules.
packages/secret-scan/src/rules/digitalocean.ts
definednetworking.ts
Code formatting and consistency improvements in Defined Networking
rules.
packages/secret-scan/src/rules/definednetworking.ts
sidekiq.ts
Code formatting and consistency improvements in Sidekiq rules.
packages/secret-scan/src/rules/sidekiq.ts
intra42.ts
Code formatting and consistency improvements in Intra42 rules.
packages/secret-scan/src/rules/intra42.ts
huggingface.ts
Code formatting and consistency improvements in Huggingface rules.
packages/secret-scan/src/rules/huggingface.ts
gitlab.ts
Code formatting and consistency improvements in GitLab rules.
packages/secret-scan/src/rules/gitlab.ts
heroku.ts
Code formatting and consistency improvements in Heroku rules.
packages/secret-scan/src/rules/heroku.ts
coinbase.ts
Code formatting and consistency improvements in Coinbase rules.
packages/secret-scan/src/rules/coinbase.ts
frameio.ts
Code formatting and consistency improvements in FrameIO rules.
packages/secret-scan/src/rules/frameio.ts
hubspot.ts
Code formatting and consistency improvements in HubSpot rules.
packages/secret-scan/src/rules/hubspot.ts
easypost.ts
Code formatting and consistency improvements in EasyPost rules.
packages/secret-scan/src/rules/easypost.ts
clojars.ts
Code formatting and consistency improvements in Clojars rules.
packages/secret-scan/src/rules/clojars.ts
flutterwave.ts
Code formatting and consistency improvements in Flutterwave rules.
packages/secret-scan/src/rules/flutterwave.ts
contentful.ts
Code formatting and consistency improvements in Contentful rules.
packages/secret-scan/src/rules/contentful.ts
beamer.ts
Code formatting and consistency improvements in Beamer rules.
packages/secret-scan/src/rules/beamer.ts
doppler.ts
Code formatting and consistency improvements in Doppler rules.
packages/secret-scan/src/rules/doppler.ts
duffel.ts
Code formatting and consistency improvements in Duffel rules.
packages/secret-scan/src/rules/duffel.ts
datadog.ts
Code formatting and consistency improvements in Datadog rules.
packages/secret-scan/src/rules/datadog.ts
lob.ts
Code formatting and consistency improvements in Lob rules.
packages/secret-scan/src/rules/lob.ts
airtable.ts
Added newline for consistency in Airtable rules.
packages/secret-scan/src/rules/airtable.ts
sendinblue.ts
Code formatting improvements for Sendinblue rule file.
packages/secret-scan/src/rules/sendinblue.ts
hashicorp.ts
Code formatting improvements for Hashicorp rule file.
packages/secret-scan/src/rules/hashicorp.ts
databricks.ts
Code formatting improvements for Databricks rule file.
packages/secret-scan/src/rules/databricks.ts
index.ts
Standardized import statement quotes in index file.
packages/secret-scan/src/rules/index.ts
age.ts
Code formatting improvements for Age rule file.
packages/secret-scan/src/rules/age.ts
readme.ts
Code formatting improvements for Readme rule file.
packages/secret-scan/src/rules/readme.ts
postman.ts
Code formatting improvements for Postman rule file.
packages/secret-scan/src/rules/postman.ts
scalingo.ts
Code formatting improvements for Scalingo rule file.
packages/secret-scan/src/rules/scalingo.ts
linear.ts
Code formatting improvements for Linear rule file.
packages/secret-scan/src/rules/linear.ts
infracost.ts
Code formatting improvements for Infracost rule file.
packages/secret-scan/src/rules/infracost.ts
rubygems.ts
Code formatting improvements for Rubygems rule file.
packages/secret-scan/src/rules/rubygems.ts
asana.ts
Code formatting improvements for Asana rule file.
packages/secret-scan/src/rules/asana.ts
prefect.ts
Code formatting improvements for Prefect rule file.
packages/secret-scan/src/rules/prefect.ts
pulumi.ts
Code formatting improvements for Pulumi rule file.
packages/secret-scan/src/rules/pulumi.ts
shippo.ts
Code formatting improvements for Shippo rule file.
packages/secret-scan/src/rules/shippo.ts
codecov.ts
Code formatting improvements for Codecov rule file.
packages/secret-scan/src/rules/codecov.ts
bittrex.ts
Code formatting improvements for Bittrex rule file.
packages/secret-scan/src/rules/bittrex.ts
page.tsx
Reordered imports in career page component.
apps/web/src/app/(main)/career/page.tsx
2 files
page.tsx
Added Gitlab logo to authentication page.
apps/platform/src/app/auth/page.tsx
index.ts
Exported GitlabSVG from auth SVG index.
apps/platform/public/svg/auth/index.ts