-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Create Item placement and style #4260
Conversation
Temorarily removes the create item button from the item screen while we work out the plan for toolbar placement
🦋 Changeset detectedLatest commit: ec0d967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Some thought on this based on my past experience with UI Hooks
it would be helpful if we can preserve the extensibility to customize the form rather than compose ourself. I know the focus is on composability rather than the ui hooks in new interface. |
The condition that caused this PR to be approved automatically changed to false, a person must approve this now.
@gautamsi that's really great feedback, I've been looking for more use-case information like this 👍 I'll open a new issue with that so we can collect it somewhere outside this PR. I'm not sure it'll stay where it is, so merged this PR as a transition, but it may change again in the next week or so as we add more actions. |
I've been playing with the placement and style of the "Create Item" button, and I think this is better than what we currently have. On the list screen, it looks like this:
It's clearer that there's now one primary action on both the list screen (create) and the item screen (save). Also putting it near the list title / filters / pagination makes it easier to see and use (this is based purely on my subjective testing, but what I'm saying is "I think it feels nice")
Separately, I've been playing with putting the "create a new {item}" and "delete" actions in a dropdown menu on the item screen, since these those are secondary actions. And I've been thinking about putting the save button up the top right where the create button currently is, as a primary action, instead of a floating toolbar; the dropdown would go next to it.
That needs some more thought and work so it'll land in another PR, but for now I've removed the create button from the item screen because (a) swapping one main button for another will be disorienting so I'd rather remove it until that decision lands, and (b) it's otherwise imo too far away from everything else - as well as too far away from where the button is on the list screen - that it's out of place and hard to use.
While navigating back to the list screen to create new items is more clicks, it feels solid and it's only temporary.