Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change createKeystone and createSystem to accept a migration mode rather than script #5087

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

emmatown
Copy link
Member

This is extracted out of #5059. There's no behavior change here, I just feel like accepting a migration mode is more clear than the current script arg.

@emmatown emmatown requested a review from a team March 10, 2021 04:27
@vercel
Copy link

vercel bot commented Mar 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/VDnYKhtGzZFsAgFEDJppM1FtEr4F
✅ Preview: https://keystone-next-git-make-create-system-accept-migration-m-67780e.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2021

🦋 Changeset detected

Latest commit: f231c5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@keystone-next/types Minor
@keystone-next/keystone Major
@keystone-next/admin-ui Major
@keystone-next/test-utils-legacy Major
@keystone-next/benchmarks-legacy Patch
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-todo Patch
@keystone-next/auth Major
@keystone-next/cloudinary Patch
@keystone-next/fields-document Patch
@keystone-next/fields Patch
@keystone-next/api-tests-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview March 10, 2021 04:32 Inactive
@emmatown emmatown changed the title Change createKeystone to accept a migration mode rather than script Change createKeystone and createSystem to accept a migration mode rather than script Mar 10, 2021
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmatown emmatown merged commit 56e5fe1 into master Mar 10, 2021
@emmatown emmatown deleted the make-create-system-accept-migration-mode branch March 10, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants