-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping node versions to 12.x #5397
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/AJZ5hRqYLKtp5eGT5mBToNFJUjmX |
🦋 Changeset detectedLatest commit: c6db4eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6db4eb:
|
Yep, that's fine 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a breaking change, so we'll want to have a major
changeset for all of our packages.
…stonejs/keystone into KEY-266/update-node-versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
https://thinkmill.atlassian.net/jira/software/projects/KEY/boards/1?selectedIssue=KEY-266
Bumping all package.json node engines to use 12.x instead of 10.x due to 10.x being end of life end of April.
When using ">=12.0.0" and installing "12.0.0" specifically, this error occurs:
error tailwindcss@2.1.0: The engine "node" is incompatible with this module. Expected version ">=12.13.0". Got "12.0.0"
Therefore minor has been bumped to "12.13.0", and installing "12.13.0" specifically builds and runs test successfully.
Therefore is it fair to say "12.13.0" is needed given tailwind can't function without it?