Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping node versions to 12.x #5397

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Bumping node versions to 12.x #5397

merged 5 commits into from
Apr 8, 2021

Conversation

bladey
Copy link
Contributor

@bladey bladey commented Apr 7, 2021

https://thinkmill.atlassian.net/jira/software/projects/KEY/boards/1?selectedIssue=KEY-266

Bumping all package.json node engines to use 12.x instead of 10.x due to 10.x being end of life end of April.

When using ">=12.0.0" and installing "12.0.0" specifically, this error occurs:

error tailwindcss@2.1.0: The engine "node" is incompatible with this module. Expected version ">=12.13.0". Got "12.0.0"

Therefore minor has been bumped to "12.13.0", and installing "12.13.0" specifically builds and runs test successfully.

Therefore is it fair to say "12.13.0" is needed given tailwind can't function without it?

@vercel
Copy link

vercel bot commented Apr 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/AJZ5hRqYLKtp5eGT5mBToNFJUjmX
✅ Preview: https://keystone-next-docs-git-key-266-update-node-versions-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2021

🦋 Changeset detected

Latest commit: c6db4eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@keystone-ui/button Major
@keystone-ui/fields Major
@keystone-ui/icons Major
@keystone-ui/loading Major
@keystone-ui/modals Major
@keystone-ui/notice Major
@keystone-ui/options Major
@keystone-ui/pill Major
@keystone-ui/popover Major
@keystone-ui/segmented-control Major
@keystone-ui/toast Major
@keystone-ui/tooltip Major
@keystone-ui/website Major
@keystone-next/website Major
@keystone-next/example-auth Major
@keystone-next/app-basic Major
@keystone-next/example-ecommerce Major
@keystone-next/example-next-lite Major
@keystone-next/example-roles Major
@keystone-next/example-sandbox Major
@keystone-next/example-todo Major
@keystone-next/admin-ui Major
@keystone-next/admin-ui-utils Major
@keystone-next/auth Major
@keystone-next/cloudinary Major
@keystone-next/fields Major
@keystone-next/keystone Major
@keystone-next/session-store-redis Major
@keystone-next/types Major
@keystone-next/access-control-legacy Major
@keystone-next/adapter-prisma-legacy Major
@keystone-next/keystone-legacy Major
@keystone-next/server-side-graphql-client-legacy Major
@keystone-next/test-utils-legacy Major
@keystone-next/utils-legacy Major
@keystone-next/api-tests-legacy Major
@keystone-next/benchmarks-legacy Major
@keystonejs/examples-smoke-tests Major
@keystone-next/fields-document Patch
keystone-next-app Patch
@keystone-next/fields-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6db4eb:

Sandbox Source
@keystone-next/example-sandbox Configuration

@bladey bladey requested a review from timleslie April 7, 2021 23:59
@bladey bladey changed the title [WIP] Bumping node versions to 12.x Bumping node versions to 12.x Apr 7, 2021
@vercel vercel bot temporarily deployed to Preview April 7, 2021 23:59 Inactive
@timleslie
Copy link
Contributor

Therefore is it fair to say "12.13.0" is needed given tailwind can't function without it?

Yep, that's fine 👍

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a breaking change, so we'll want to have a major changeset for all of our packages.

@vercel vercel bot temporarily deployed to Preview April 8, 2021 00:58 Inactive
@bladey bladey requested a review from timleslie April 8, 2021 00:59
@vercel vercel bot temporarily deployed to Preview April 8, 2021 01:36 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bladey bladey enabled auto-merge (squash) April 8, 2021 01:37
@bladey bladey merged commit a562730 into master Apr 8, 2021
@bladey bladey deleted the KEY-266/update-node-versions branch April 8, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants