-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Prisma SHADOW_DATABASE_URL #7350
Support Prisma SHADOW_DATABASE_URL #7350
Conversation
🦋 Changeset detectedLatest commit: d906a85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/9v27Gr41L19qEPYucNwfuLy3RR1t |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d906a85:
|
cb7b5bc
to
1288906
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dcousens thanks for running the pipeline! @bladey we’ve double checked the GraphQL schema updates #6982 (comment) @molomby we implemented your suggestions from #6982 (comment) Thank you all for your help! Let me know if there’s anything else needed to move this PR along. |
e6c203a
to
25de5b5
Compare
@dcousens any updates? 🤞 |
c68c094
to
6b45119
Compare
Hi @jlarmstrongiv, we haven't forgotten this, the only remaining block is to verify the desired behaviour around the We want to see if we can always provide the shadow database URL, and hoping that, it being blank reverts to the default behaviour. |
Thanks for the update @dcousens much appreciated 👍 Yes, we implemented it similar to prisma flags |
Hi @jlarmstrongiv Thanks for your reply, we are wanting to avoid the If you were to alway print Let me know if you have any questions. |
@borisno2 Thank you for following up! Oh I see, theoretically yes. Back in February, the prisma/prisma-engines#1672 was recently merged and KeystoneJS was depending on an older version of prisma, so that was not possible at the time. Now, with KeystoneJS depending on prisma@3.14.0 (released a month ago), including |
6b45119
to
593effc
Compare
Co-authored-by: John Armstrong <jlarmstrongiv@users.noreply.github.com>
Co-authored-by: John Armstrong <jlarmstrongiv@users.noreply.github.com>
Co-authored-by: John Armstrong <jlarmstrongiv@users.noreply.github.com>
593effc
to
c7611e0
Compare
@borisno2 we updated the PR with your suggestions 🚀 would you run the the workflow? |
Co-authored-by: John Armstrong <jlarmstrongiv@users.noreply.github.com>
Interesting! We now set it to an empty string instead, which should work https://github.com/prisma/prisma-engines/pull/1672/files#diff-c1428df746767db7244ee782e01a8c5cd941e55218ee25ace07da1eece5907e7R169 Would you re-run the workflow @borisno2 ? |
@borisno2 fixed some hard-coded schema tests, let’s try again 🚀 another workflow re-run? |
3f23f25
to
25d7064
Compare
specifically alignment via spaces
25d7064
to
7802a08
Compare
Rationale: When using shadow databases, you must use the
shadowDatabaseUrl
API field per the Prisma documentation.Implementation: We supported passing
DatabaseConfig.shadowDatabaseUrl
in the Keystone config object.Relevant Links:
Follow-up From: