-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ExtendGraphqlSchema
type alias
#8397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e449ce4:
|
dcousens
force-pushed
the
remove-extend-graphql-schema-type-alias
branch
from
March 20, 2023 00:06
838a631
to
f6552e7
Compare
@dcousens Leveraging that you are selling ExtendGraphQLSchema, I would like to request a support for asynchronous!! Can it be possible? |
@ganobrega I can't see why not, what's your usecase? |
dcousens
force-pushed
the
remove-extend-graphql-schema-type-alias
branch
from
August 9, 2023 07:20
f6552e7
to
cc3c810
Compare
borisno2
approved these changes
Aug 9, 2023
Merged
dcousens
added a commit
that referenced
this pull request
Aug 15, 2023
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Aug 30, 2023
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Sep 10, 2023
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 2, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 2, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 2, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 3, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens
added a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
ExtendGraphqlSchema
type alias, which is a breaking change.This type alias was unnecessarily exported, and is easily replaced by the more informative to the reader, explicit type:
This pull request should only be merged when we have other breaking changes.