Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExtendGraphqlSchema type alias #8397

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Mar 20, 2023

This pull request removes the ExtendGraphqlSchema type alias, which is a breaking change.
This type alias was unnecessarily exported, and is easily replaced by the more informative to the reader, explicit type:

import type { GraphQLSchema } from 'graphql'

// ...

(schema: GraphQLSchema) => GraphQLSchema

This pull request should only be merged when we have other breaking changes.

@changeset-bot

This comment was marked as resolved.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e449ce4:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens force-pushed the remove-extend-graphql-schema-type-alias branch from 838a631 to f6552e7 Compare March 20, 2023 00:06
@ganobrega
Copy link
Contributor

@dcousens Leveraging that you are selling ExtendGraphQLSchema, I would like to request a support for asynchronous!! Can it be possible?

@dcousens
Copy link
Member Author

@ganobrega I can't see why not, what's your usecase?

@dcousens dcousens enabled auto-merge (squash) April 26, 2023 23:13
@dcousens dcousens self-assigned this Jun 8, 2023
@dcousens dcousens force-pushed the remove-extend-graphql-schema-type-alias branch from f6552e7 to cc3c810 Compare August 9, 2023 07:20
@dcousens dcousens merged commit a60ffa8 into main Aug 9, 2023
56 of 57 checks passed
@dcousens dcousens deleted the remove-extend-graphql-schema-type-alias branch August 9, 2023 07:35
dcousens added a commit that referenced this pull request Aug 15, 2023
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Aug 30, 2023
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Sep 10, 2023
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Mar 28, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Mar 28, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 2, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 2, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 2, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 3, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
dcousens added a commit that referenced this pull request Apr 4, 2024
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants