-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new parallel makefile for gcc torture test #57
add new parallel makefile for gcc torture test #57
Conversation
please let me know if I have failed to capture any of the functionality the old torture test had. |
@@ -0,0 +1,19 @@ | |||
TESTS = $(wildcard ./*.c) | |||
GCC_COMPILED_TESTS = ${TESTS:.c=.gcc} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, right. I meant to include another target about that. Give me a sec to update the diff.
It looks fine, although I think runtest.pl did a bit more (e.g., it compared the stdout/err of the kcc compiled version with the gcc compiled version). I'm not entirely sure if that matters for the torture tests or not. |
@chathhorn please review again Note that I'm pretty sure that runtest.pl was actually broken as far as running gcc goes, because there seem to be a number of failed tests in this directory when I try to compile with gcc. But the targets are separated out now so that you can run kcc without running gcc, while still being able to compare the output if you choose. |
GCC used to fail about 8 of the tests. I'm pretty sure at least some of the torture tests also use stdout/stderr. -Chucky On Fri, Nov 21, 2014 at 10:20 AM, dwightguth notifications@github.com
|
Looks good. |
add new parallel makefile for gcc torture test
@chathhorn please review