auto hide device-chooser when there are no devices #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… device found, otherwise it will be hidden. also updated _deviceAdded and _deviceRemoved to invoke '_setVisibility' hide/show when number of devices changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I love this extension but 1 small issue bugged me.
if you have no input devices connected (no mic), the extension will show 'Extension initializing..." forever (where the input-device chooser should be).
So I fixed it here by automatically hiding the device-chooser if there are currently 0 known devices.
Feel free to comment me if I did this fix in a bad way and you would do it differently.
from my commit msg: