Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile flag to also generate mobile friendly files #50

Closed
wants to merge 58 commits into from

Conversation

ZXY101
Copy link
Contributor

@ZXY101 ZXY101 commented Apr 16, 2023

Description

Add a new mobile flag, when true it will generate additional mobile optimized files:
.mobile.html, styles.mobile.css and script.mobile.js (given that as_one_file is false).

The default functionality should be exactly the same, as for the mobile files:

  • Removed panzoom and related functionality
  • Make the background black and add simple navigation buttons to the bottom of the screen
  • Add in in swipe-to-navigate functionality

Panzooms bounds options does not seem to work correctly so there doesn't seem to be a way to not navigate off screen into the void which is quite annoying. So I've removed panzoom and just handle resizing the page to the screen. For panning and zooming the browser should handle that by default, I've just added some additional touch event logic to be able to change pages via swiping.

Usage

$> mokuro "my-manga-01" --mobile True --disable_confirmation True
'// _ocr, my-manga-01.html, my-manga-01.mobile.html'

$> mokuro "my-manga-01" --mobile True --disable_confirmation True --as_one_file False
'// _ocr, my-manga-01.html, script.js, styles.css, panzoom.min.js'
'// my-manga-01.mobile.html, script.mobile.js, styles.mobile.css'

Video

Viewing in jidoujisho's manga viewer

video_2023-04-16_14-17-15.mp4

I've mainly done this for my own usage, I can't confirm if this works as expected on other devices especially IOS.
I tried to make sure I didn't effect the default experience in any way, can still be improved some but it's at a point where I can comfortably use without issue.

@ZXY101
Copy link
Contributor Author

ZXY101 commented Apr 22, 2023

Hey @kha-white, any chance you could look at this?

Is this project still being maintained?

@ZXY101 ZXY101 closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant