-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile flag to also generate mobile friendly files #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @kha-white, any chance you could look at this? Is this project still being maintained? |
…obile friendly files
…+overhaul Feature/anki connect implementation+overhaul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new
mobile
flag, when true it will generate additional mobile optimized files:.mobile.html
,styles.mobile.css
andscript.mobile.js
(given thatas_one_file
is false).The default functionality should be exactly the same, as for the mobile files:
Panzooms bounds options does not seem to work correctly so there doesn't seem to be a way to not navigate off screen into the void which is quite annoying. So I've removed panzoom and just handle resizing the page to the screen. For panning and zooming the browser should handle that by default, I've just added some additional touch event logic to be able to change pages via swiping.
Usage
Video
Viewing in jidoujisho's manga viewer
video_2023-04-16_14-17-15.mp4
I've mainly done this for my own usage, I can't confirm if this works as expected on other devices especially IOS.
I tried to make sure I didn't effect the default experience in any way, can still be improved some but it's at a point where I can comfortably use without issue.