Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate malformed SDMX-JSON from OECD #81

Merged
merged 5 commits into from Jun 27, 2021
Merged

Tolerate malformed SDMX-JSON from OECD #81

merged 5 commits into from Jun 27, 2021

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Jun 27, 2021

No description provided.

@khaeru khaeru self-assigned this Jun 27, 2021
@khaeru khaeru linked an issue Jun 27, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #81 (cb72ba7) into main (8fc21b3) will decrease coverage by 2.06%.
The diff coverage is 100.00%.

❗ Current head cb72ba7 differs from pull request most recent head d2fad75. Consider uploading reports for the commit d2fad75 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   97.48%   95.41%   -2.07%     
==========================================
  Files          53       53              
  Lines        4614     4628      +14     
==========================================
- Hits         4498     4416      -82     
- Misses        116      212      +96     
Impacted Files Coverage Δ
sdmx/tests/test_sources.py 71.20% <ø> (-28.80%) ⬇️
sdmx/model.py 97.30% <100.00%> (+0.11%) ⬆️
sdmx/reader/json.py 100.00% <100.00%> (+1.25%) ⬆️
sdmx/testing.py 99.21% <100.00%> (+0.01%) ⬆️
sdmx/tests/test_model.py 100.00% <100.00%> (ø)
sdmx/source/wb_wdi.py 28.57% <0.00%> (-71.43%) ⬇️
sdmx/source/ilo.py 50.00% <0.00%> (-50.00%) ⬇️
sdmx/source/lsd.py 50.00% <0.00%> (-50.00%) ⬇️
sdmx/source/insee.py 57.14% <0.00%> (-42.86%) ⬇️
sdmx/source/istat.py 57.14% <0.00%> (-42.86%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc21b3...d2fad75. Read the comment docs.

@khaeru khaeru merged commit 1cefd5c into main Jun 27, 2021
@khaeru khaeru deleted the issue/64 branch June 27, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OECD "PART2" JSON cannot be parsed
1 participant