Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-552] Adding a new card should always select the newly added card #944

Merged
merged 8 commits into from
Nov 13, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Nov 12, 2019

📲 What

Fixes a bug where if you added a new card in the change payment method context, it did not automatically select.

🤔 Why

Because adding a new card should always select the newly added card.

🛠 How

If we are working with a project that has a backing, and a new card is added, ignore the card that was used to back and instead select the newly added card.

👀 See

KqccA7F1BH

♿️ Accessibility

N/A

🏎 Performance

N/A

✅ Acceptance criteria

  • As a user with stored cards Navigate to the pledge screen on any project -- the first stored card should be selected. If you add a payment method on the pledge screen, the newly added payment method should be selected.
  • As a user without stored cards Navigate to the pledge screen on any project -- the "Pledge" button should be disabled. If you add a payment method on the pledge screen, the newly added payment method should be selected.
  • As a user with stored cards Navigate to the "Manage pledge" screen, then tap "Change payment method" -- the card you used to back that project should be at the front of the list, and selected. Then, if you add a new payment method, the newly added payment method should be selected and the "Confirm" button should be enabled.
  • Back a project with a stored card, then delete the stored card in Settings -> Account -> Payment Methods -- then, navigate to "Manage pledge" and tap "Change payment method". None of the stored cards should be selected. Then, if you add a new payment method, the newly added payment method should be selected and the "Confirm" button should be enabled.

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@justinswart justinswart merged commit cc754ca into master Nov 13, 2019
@justinswart justinswart deleted the NT-552-added-card-selected branch November 13, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants