Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-552] Fix selecting card regression #946

Merged
merged 6 commits into from
Nov 13, 2019
Merged

Conversation

ifbarrera
Copy link
Contributor

📲 What

Fixes a regression introduced in #944 whereby if you added a new card, then selected a different card, you couldn't re-select the newly added card.

🛠 How

Refactors the approach for adding a new card slightly. We brought back the scan, and fed the result (allCards) to the self.updateSelectedCreditCard signal. Also adds a test to cover this case.

👀 See

Trello, screenshots, external resources?

Before 🐛 After 🦋
Mrn7gj1MaW n2DXYmDsjd

♿️ Accessibility

N/A

🏎 Performance

N/A

✅ Acceptance criteria

  • On the pledge screen, add a new card. You should see the new card selected. Then, select a different card from the list. Then, re-select the newly added card. The card should select properly.

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, "checks out!"

@ifbarrera ifbarrera merged commit e0aa993 into master Nov 13, 2019
@ifbarrera ifbarrera deleted the fix-add-new-card-select branch November 13, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants