[NT-552] Fix selecting card regression #946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes a regression introduced in #944 whereby if you added a new card, then selected a different card, you couldn't re-select the newly added card.
🛠 How
Refactors the approach for adding a new card slightly. We brought back the
scan
, and fed the result (allCards
) to theself.updateSelectedCreditCard
signal. Also adds a test to cover this case.👀 See
Trello, screenshots, external resources?
♿️ Accessibility
N/A
🏎 Performance
N/A
✅ Acceptance criteria